Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve pkgDir to absolute path #25

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: resolve pkgDir to absolute path #25

merged 1 commit into from
Aug 24, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 24, 2023

Resolve pkgDir to an absolute path. This value is passed to publint and execa's cwd option. For example, before "packages/vite"; after "/Users/foo/vite/packages/vite".

I don't think (?) passing a relative path works for publint, maybe it works for execa, but using absolute anyways should be safest.

@patak-dev patak-dev merged commit e67ab52 into main Aug 24, 2023
1 check passed
@patak-dev patak-dev deleted the absolute-publish branch August 24, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants